Szelethus added a comment.

In D62899#1551312 <https://reviews.llvm.org/D62899#1551312>, @NoQ wrote:

> In D62899#1549715 <https://reviews.llvm.org/D62899#1549715>, @Szelethus wrote:
>
> > Added a proper testfile. The only downside of it is that it doesn't test 
> > anything.
>
>
> Use creduce!


I would, but I'm not even sure what to look for, really.

Okay, I have a far better understanding of interestingness, so here's the deal: 
Visitors, like `ConditionBRVisitor`, will mark its diagnostics non-prunable if 
it describes an interesting entity. The problem is, for an uninitialized 
variable, everything that is worth explaining is probably unexplored by the 
analyzer, leaving only to the note "Declaring 'x' without an initial value", 
which we don't emit for C++ constructors.

That said, I'd like `ReturnVisitor` to step up and place the notes it usually 
does. Even better, I'd like to use `trackRegionValue()` to add our beloved 
selection of visitors, so its a real shame it doesn't exist :^) Since we mark 
tracked values as interesting anyways, that would be a better solution then 
this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62899/new/

https://reviews.llvm.org/D62899



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D62899: [analyzer]... Kristóf Umann via Phabricator via cfe-commits

Reply via email to