alexfh added inline comments. ================ Comment at: test/clang-tidy/readability-braces-around-statements-assert-failure.cpp:13 @@ +12,3 @@ + std::vector<int> e; + for (typename std::vector<T>::const_reverse_iterator iter = e.begin(), + end2 = e.end(); ---------------- Can you further reduce the test case so it still causes a crash, but doesn't generate so many compilation errors?
The problem with matching compilation errors in clang-tidy tests is that a change in Clang parser can break clang-tidy tests. The more errors you verify, the higher the chance of this kind of a breakage. If we need to verify clang errors, we should keep their number minimal. Repository: rL LLVM http://reviews.llvm.org/D17134 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
