andreybokhanko added a comment. In http://reviews.llvm.org/D16851#349537, @silvas wrote:
> Assuming the features are implemented this seems fine. LGTM. Thank you! ================ Comment at: docs/UsersManual.rst:1698 @@ -1697,3 @@ -- clang does not support #pragma weak (`bug - 3679 <http://llvm.org/bugs/show_bug.cgi?id=3679>`_). Due to the uses - described in the bug, this is likely to be implemented at some point, ---------------- silvas wrote: > Should we close that bug then? As often happens, this bug started as a general feature request ("pragma weak doesn't work at all"), but the last few messages just report a specific defect in a specific case and keep the PR open. I will ask one of our (Intel) engineers to take a look and either close the PR if the bug is already fixed or fix it otherwise. Andrey http://reviews.llvm.org/D16851 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
