NoQ marked 2 inline comments as done.
NoQ added inline comments.
================
Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:846
+ print(' $ dot -Tsvg input.dot -o output.svg')
+ print()
+ write_temp_file('.dot', self.output())
----------------
Charusso wrote:
> Why we need multiple prints to print one message? According to the Stack
> Overflow:
> ```
> print("""
> Line1
> Line2
> """)
> ```
>
> Link:
> https://stackoverflow.com/questions/34980251/how-to-print-multiple-lines-of-text-with-python
I dislike what it does to my formatting. We're in 4 nested scopes and it
suddenly requires me to make an un-indented block.
================
Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:953
+ 'displaying it, dump the rewritten dot file '
+ 'to stdout')
args = parser.parse_args()
----------------
Charusso wrote:
> This flag is a little-bit too long and does not really emphasize what it
> suppose to do. What about just `--dump` or `--stdout`?
Renamed to `--dump-dot-only`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65250/new/
https://reviews.llvm.org/D65250
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
