hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: clang/test/Driver/frame-pointer-elim.c:1 +// KEEP-ALL-NOT: warning: // KEEP-ALL: "-mframe-pointer=all" ---------------- This is the first time I've seen the CHECK lines come before the FileCheck invocations. That's not due to this patch of course, but maybe they could be moved in a follow-up? ================ Comment at: clang/test/Driver/frame-pointer-elim.c:31 +// fno-no-omit-frame-pointer -momit-leaf-frame-pointer can be overwritten by +// fomit-frame-pointer later on the command without warning ---------------- -fno-no? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66142/new/ https://reviews.llvm.org/D66142 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
