aaron.ballman added inline comments.
================ Comment at: clang/lib/Parse/ParsePragma.cpp:2697 PP.Lex(Tok); + StringRef ExpectedArgumentText; + switch (*FlagKind) { ---------------- sepavloff wrote: > aaron.ballman wrote: > > Same here. > This case is different from the above, the list of expected arguments depend > on the current option. The case isn't different in the way that matters -- all of the strings that get passed in to the diagnostic come from string literals. You should be able to put the literals into the %select and map `TokFPAnnotValue::*` to an index, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65997/new/ https://reviews.llvm.org/D65997 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits