juliehockett accepted this revision. juliehockett marked an inline comment as done. juliehockett added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" instead of a "../D". It is correct + // but it would be better to have the shorter version. StringRef Dir = Directory; ---------------- DiegoAstiazaran wrote: > DiegoAstiazaran wrote: > > juliehockett wrote: > > > Would `llvm::sys::path::remove_dots()` do this? It might not, but is > > > worth investigating. > > `llvm::sys::path::remove_dots()` removes all `../` (except for leading > > `../`) so the resulting path in the example would be `../A/B/D`, which is > > not correct. > Sorry about that, I was incorrect. `llvm::sys::path::remove_dots()` do what > we want but from the right side of the path, not the left side. > For `A/B/C/../..` it changes it to `A`. So it still does not work for us. That's irritating :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65987/new/ https://reviews.llvm.org/D65987 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
