alexfh added a comment. One more nit.
================ Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:674 + return !( + (isTokAtEndOfExpr(Lsr, LTok, SM) && isTokAtEndOfExpr(Rsr, RTok, SM)) && + isSameToken(LTok, RTok, SM)); ---------------- aaron.ballman wrote: > You can drop a set of parens here as they don't change the order of > evaluation. I'd propagate the negation into the parentheses. I find it easier to understand `!a || !b || !c` than `!(a && b && c)`, since the former can be digested piece by piece, but the latter requires the reader to keep the `!` in their mind and "recurse" into the nested parentheses. It's similar to the "early return" pattern vs. nested conditional statements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55125/new/ https://reviews.llvm.org/D55125 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
