Szelethus added a comment. In D66042#1624468 <https://reviews.llvm.org/D66042#1624468>, @Szelethus wrote:
> Speaking about performance impact, note where your patch does the actual > silencing: by the time control reaches that point, we created bug report > equivalence classes, constructed a trimmed version of the exploded graph, > constructed a bug path from that trimmed graph and ran all visitors on and > have gathered all diagnostic pieces for it (plenty of shared object creations > there). I have a strong suspicion that not even creating the bug report is > far faster. I mean, simply changing where the silencing happens would solve most of these, of course, though there still would be things we'd have to pay for one way or another. I see your point with the boilerplate code however, we could definitely improve on that part of the interface. I wouldn't call the current situation so bad thought that I'd restrain myself from adding a couple more checkers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
