jvikstrom added inline comments.

================
Comment at: 
clang-tools-extra/clangd/clients/clangd-vscode/test/assets/firstIncludedTheme.jsonc:3
+    // Some comment
+    "include": "secondIncludedTheme.jsonc",
+    "tokenColors": [
----------------
hokein wrote:
> nit: any reason use `jsonc` not `json`?
> 
By default vscode will bind .json files to normal json files which don't allow 
comments. So if you'd try to run the tests without having set .json to bind to 
json with comments than it will be a "compile error" because of vscode not 
allowing comments in .json.
 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65738/new/

https://reviews.llvm.org/D65738



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to