rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
lgtm if you clarify that bit ================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1676 @@ -1675,2 +1675,3 @@ - llvm::GlobalValue::LinkageTypes VFTableLinkage = CGM.getVTableLinkage(RD); + llvm::GlobalValue::LinkageTypes VFTableLinkage = + RD->hasAttr<DLLImportAttr>() ? llvm::GlobalValue::LinkOnceODRLinkage ---------------- According to you, this is a crazy special case, add comments. :) http://reviews.llvm.org/D17061 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
