[PATCH] D65615: [BPF] annotate DIType metadata for builtin preseve_array_access_index()

[Alexei Starovoitov via Phabricator via cfe-commits]

ast added inline comments.


================
Comment at: lib/CodeGen/CGExpr.cpp:3402
                                      QualType eltType, bool inbounds,
-                                     bool signedIndices, SourceLocation loc,
+                                     bool signedIndices, QualType *arrayType,
+                                     SourceLocation loc,
----------------
would it make sense to reorder and make it 'QualType *arrayType = nullptr', so 
only explicit pointers would be passed and the rest will get 'nullptr' 
automatically?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65615/new/

https://reviews.llvm.org/D65615



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits