rnk added a comment.

Thanks!



================
Comment at: include/clang/Basic/LangStandard.h:19
+/// standard and possible actions.
+enum Language {
+  Unknown,
----------------
Is it feasible to make this an `enum class`? I'm worried about namespace 
clashes on these otherwise very short names, like C, CXX, HIP, etc. It should 
be straightforward and mechanical to replace most existing instances of 
`InputKind::` with `Language::`. It would also remove the need to make an 
exception for `LF_OpenCL`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65562/new/

https://reviews.llvm.org/D65562



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to