It's best not to commit things without approval once they've been sent for review (the assumption being that if you asked for review it's because the change needed review - time doesn't change that fact) - if approval was given off-list (eg: on IRC) it's best to mention who gave it & where (& ideally the person should provide it on-list just for record keeping)
On Tue, Feb 9, 2016 at 4:16 PM, Katya Romanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL260333: This patch adds doxygen comments for all the > intrinsincs in the header fileā¦ (authored by kromanova). > > Changed prior to commit: > http://reviews.llvm.org/D17021?vs=47299&id=47394#toc > > Repository: > rL LLVM > > http://reviews.llvm.org/D17021 > > Files: > cfe/trunk/lib/Headers/f16cintrin.h > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits