martong added inline comments.

================
Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:489
+  if (DisplayCTUProgress) {
+    if (llvm::Expected<std::string> FileName =
+            ASTStorage.getFileForFunction(LookupName, CrossTUDir, IndexName))
----------------
` LoadOperation` should not be successful if the condition here is true.
Perhaps `LoadOperation.wasSuccessful();` should be done right before the last 
return stmt in the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64753/new/

https://reviews.llvm.org/D64753



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to