ilya-biryukov added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:408 +} + } // namespace ---------------- ilya-biryukov wrote: > Could you also add a separate test that checks diffs when the number of lines > is getting smaller (i.e. taking `NLines` into account) I would expect this to be better handled outside `checkDiffedHighlights` to avoid over-generalizing this function. But up to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
