NoQ added a comment.

It's counter-idiomatic to pass manager objects (`ProgramStateManager`, 
`SValBuilder`, etc.) as const-references because it tells you pretty much 
nothing about what you can or cannot do with them. You don't really ever 
semantically mutate them in the first place.

But when it comes to actual data structures such as `ExplodedGraph`, we should 
totally be doing this, yeah :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65382/new/

https://reviews.llvm.org/D65382



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to