shafik added a comment.
First round of review.
================
Comment at: clang/lib/AST/ASTImporter.cpp:2632
+ ExpectedName NameOrErr = Importer.HandleNameConflict(
+ Name, DC, IDNS, ConflictingDecls.data(), ConflictingDecls.size());
+ if (!NameOrErr)
----------------
`Name` -> `SearchName`
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:2392
+struct ImportFunctionTemplates : ASTImporterOptionSpecificTestBase {};
+
----------------
What about tests for name conflicts for:
`NamespaceDecl`
`TypedefNameDecl`
`TypeAliasTemplateDecl`
`EnumConstantDecl`
`RecordDecl`
`VarDecl`
Who were also modified above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59692/new/
https://reviews.llvm.org/D59692
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
