mgehre marked 9 inline comments as done. mgehre added inline comments.
================ Comment at: clang/test/SemaCXX/attr-gsl-owner-pointer-parsing.cpp:2 +// RUN: %clang_cc1 -fsyntax-only -verify %s + +int [[gsl::Owner]] i; ---------------- aaron.ballman wrote: > This file tests part of parsing and part of Sema somewhat interchangeably. > I'm not strictly opposed to it being that way, but it would be a bit cleaner > to have the parsing tests in the Parser directory and the rest in SemaCXX > (that also reduces the confusion from the file name). I had split the tests into two files due to a misconception that the ast-dump would not work when errors are emitted. It actually does work, and so I recombined the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63954/new/ https://reviews.llvm.org/D63954 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
