Anastasia marked an inline comment as done.
Anastasia added inline comments.


================
Comment at: include/clang/Frontend/LangStandards.def:177
 LANGSTANDARD_ALIAS_DEPR(opencl20, "CL2.0")
+LANGSTANDARD_ALIAS_DEPR(openclcpp, "CLC++")
 
----------------
svenvh wrote:
> It surprised me that the capitalized aliases for the (non-C++) CL standards 
> are considered deprecated, because the OpenCL spec only mentions the 
> capitalized variants.  The deprecation was introduced by 59456511f4 ("Improve 
> diagnostics for bad -std= flag.", 2017-04-27).  It doesn't seem to have any 
> practical implications though.
> 
> The convention for non-OpenCL standards seems to be all lowercase though 
> (e.g. `c99`, `c++14`, so it sounds reasonable to mark the capitalized `CLC++` 
> as deprecated.
Yeah, a misalignment indeed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65102/new/

https://reviews.llvm.org/D65102



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to