thakis marked an inline comment as done.
thakis added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051
+  // Claim flags for the integrated assembler only if it's being used.
+  if (IsIntegratedAs) {
+    if (UseRelaxAll(C, Args))
----------------
nickdesaulniers wrote:
> thakis wrote:
> > (This just wraps all the red lines on the lhs in an `if (IsIntegratedAs)` 
> > and leaves them all otherwise unchanged.)
> Return early on negated condition instead of adding additional indentation 
> and messing with `git blame`.
It doesn't skip the whole function, just the first few flags.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65108/new/

https://reviews.llvm.org/D65108



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to