gtbercea marked an inline comment as done. gtbercea added inline comments.
================ Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2610 + auto *GV = cast<llvm::GlobalVariable>(Ptr); + GV->setLinkage(llvm::GlobalValue::WeakAnyLinkage); + ---------------- gtbercea wrote: > ABataev wrote: > > Better to fix the link clause processing in a different patch, it has > > nothing to do with the unified memory. > Sure I can split this patch. It turns out that the patch cannot be split. Splitting the patch would lead to an intermediate state which produced incorrect results for certain corner cases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64592/new/ https://reviews.llvm.org/D64592 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
