hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/SourceCode.cpp:332
+bool isInsideMainFile(SourceLocation Loc, const SourceManager &SM) {
+ return Loc.isValid() && SM.isWrittenInMainFile(SM.getFileLoc(Loc));
+}
----------------
ilya-biryukov wrote:
> NIT: why not `getExpansionLoc`? Its implementation and description seems
> simpler and (I believe) it produces locations inside the same files as
> `getFileLoc` (as both the macro arg and the macro name of the expansion are
> always coming from the same file)
yes, since we are checking the file (not the range), there is no difference
between these two methods. Changed to `getExpansionLoc`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64915/new/
https://reviews.llvm.org/D64915
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
