sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:428
+ llvm::json::Object TMScopes{{"scopes", buildHighlightScopeLookupTable()}};
+ // Theia needs the text mate scopes in the normal capabilities object.
if (Params.capabilities.SemanticHighlighting)
----------------
these comments (and also the one in Protocol.h) lack context: it's easy to
understand what they're saying when looking at this patch, but hard when just
looking at the code.
Maybe something like "There are two slightly different versions of the semantic
highlighting capabilities: one in the 'main' namespace (supported by Theia),
and one in the 'experimental' namespace (supported by VSCode)"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64922/new/
https://reviews.llvm.org/D64922
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
