martong accepted this revision. martong added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: include/clang/AST/ASTImporter.h:288 + ASTContext &FromContext, FileManager &FromFileManager, + ASTUnit *FromUnit, bool MinimalImport, + std::shared_ptr<ASTImporterSharedState> SharedState); ---------------- balazske wrote: > martong wrote: > > Why do we still need `FromUnit` in this ctor? I thought the other ctor > > would handle that case. > This is a private and common constructor that can handle both cases (called > by the others). Ok, I've missed that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64554/new/ https://reviews.llvm.org/D64554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
