mcgrathr added inline comments.
================ Comment at: clang/lib/Basic/Targets/X86.h:858 + : FuchsiaTargetInfo<X86_64TargetInfo>(Triple, Opts) { + LongDoubleFormat = &llvm::APFloat::IEEEquad(); + } ---------------- Can we just do this in FuchsiaTargetInfo generically? I think we'd like to make our core API types uniform across machines and this makes sure that we get the Fuchsia common choice rather than a machine-specific choice that might differ in a new machine. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64603/new/ https://reviews.llvm.org/D64603 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits