martong added a comment.

In D64628#1584969 <https://reviews.llvm.org/D64628#1584969>, @balazske wrote:

> The mentioned commit has a test that reproduces the same problem, so this 
> revision is not needed (abandon it?).


I think we should have this change, because it tests also if we can import the 
"extern implicit" function properly. Plus the bug visitor is exercised when the 
AST is merged.
So, even if the mentioned commit has a similar test I think with these changes 
we can achieve higher coverage and can prevent CTU related regression.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64628/new/

https://reviews.llvm.org/D64628



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to