kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/SourceCode.cpp:252
-llvm::Optional<SourceRange> toHalfOpenFileRange(const SourceManager &Mgr,
+// FIXME: Here we check whether the token at the location is a greatergreater
+// (>>) token and consider it as a single greater (>). This is to get it
working
----------------
maybe move the comment to just before `if(thetok.is(greatergreater))` check?
================
Comment at: clang-tools-extra/clangd/SourceCode.cpp:260
+ Token TheTok;
+ if (!Lexer::getRawToken(Loc, TheTok, SM, LangOpts)) {
+ if (TheTok.is(tok::greatergreater))
----------------
re-arrange for less indentation:
```
if(Lexer::getRawToken(...))
return 0;
if(TheTok.is(tok::greater...)
return 1;
return TheTok...;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64562/new/
https://reviews.llvm.org/D64562
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
