kadircet marked an inline comment as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:121
// Should we also preserve flags like "-sysroot", "-nostdinc" ?
- const llvm::StringRef Args[] = {
- Driver, "-E", "-x", driver::types::getTypeName(Type), "-", "-v"};
+ const llvm::StringRef Args[] = {Driver, "-E", "-x", Lang, "-", "-v"};
----------------
sammccall wrote:
> does gcc accept the same set of -x flags?
It seems to be the case. Relevant section of manpage for gcc:
```
You can specify the input language explicitly with the -x option:
-x language
Specify explicitly the language for the following input files
(rather than letting the compiler choose a default based on the
file name suffix). This option applies to all following input
files until the next -x option. Possible values for language
are:
c c-header cpp-output
c++ c++-header c++-cpp-output
objective-c objective-c-header objective-c-cpp-output
objective-c++ objective-c++-header objective-c++-cpp-output
assembler assembler-with-cpp
ada
d
f77 f77-cpp-input f95 f95-cpp-input
go
brig
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64489/new/
https://reviews.llvm.org/D64489
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
