hokein marked an inline comment as done. hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/Selection.cpp:367 } - return nullptr; } ---------------- sorry, the previous patch rL365751 didn't fix the crash, and I re-read the code more thoroughly, I think we will never hit this point, need you confirmation, @sammccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64556/new/ https://reviews.llvm.org/D64556 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
