probinson added a comment. In D63894#1574419 <https://reviews.llvm.org/D63894#1574419>, @dblaikie wrote:
> I would've assumed these conditionals were added by Sony folks for their > change in default dialect - that doesn't necessarily mean these tests are > needed upstream (the functionality may be tested elsewhere) For two of the files, the conditionals were added by Richard Smith, not Sony. For the Sony case, it is the *older* path that was upstream originally, and that is the one that the tests stopped testing; there is no reason to think those paths are tested elsewhere. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63894/new/ https://reviews.llvm.org/D63894 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits