NoQ added inline comments.
================
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1060
+public:
+ const static unsigned NoArgRequirement =
std::numeric_limits<unsigned>::max();
+
----------------
Charusso wrote:
> What about `Optional<>`? When I first met that function I have fallen in love.
I didn't really touch this code, just moved it around, but it's definitely a
valid point.
================
Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:103
+ {{"foo"}, true},
+ }), "void foo(); struct bar { void foo(); }; void test() { foo(); }"));
+
----------------
Charusso wrote:
> So `{{"bar", "foo"}, true}`? I like puzzles, but it would be cool to state
> out why it is negative as other tests all have negative sub-tests.
`{{"bar", "foo"}, false}`!
Nice catch tho, typo.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62441/new/
https://reviews.llvm.org/D62441
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
