nickdesaulniers added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:401
+      case Stmt::GCCAsmStmtClass:
+        assert(cast<GCCAsmStmt>(Term)->isAsmGoto() == true && "Encountered 
GCCAsmStmt without labels");
+        // TODO: Handle jumping to labels
----------------
prefer: `assert(shouldBeTrue() && "asdfasdf")` to `assert(shouldBeTrue() == 
true && "asfas")`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63533/new/

https://reviews.llvm.org/D63533



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to