Author: hokein Date: Thu Jun 27 05:22:18 2019 New Revision: 364528 URL: http://llvm.org/viewvc/llvm-project?rev=364528&view=rev Log: [clangd] No need to setTraversalScope in SemanticHighlighting.
Summary: We have already set it when the AST is being built, and setting TraversalScope is not free (it will clear the cache, which is expensive to build). Reviewers: jvikstrom Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D63874 Modified: clang-tools-extra/trunk/clangd/SemanticHighlighting.cpp clang-tools-extra/trunk/clangd/SemanticHighlighting.h Modified: clang-tools-extra/trunk/clangd/SemanticHighlighting.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/SemanticHighlighting.cpp?rev=364528&r1=364527&r2=364528&view=diff ============================================================================== --- clang-tools-extra/trunk/clangd/SemanticHighlighting.cpp (original) +++ clang-tools-extra/trunk/clangd/SemanticHighlighting.cpp Thu Jun 27 05:22:18 2019 @@ -1,4 +1,4 @@ -//===--- SemanticHighlighting.cpp - -------------------------- ---*- C++ -*-===// +//===--- SemanticHighlighting.cpp - ------------------------- ---*- C++ -*-===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. @@ -70,7 +70,6 @@ bool operator==(const HighlightingToken } std::vector<HighlightingToken> getSemanticHighlightings(ParsedAST &AST) { - AST.getASTContext().setTraversalScope(AST.getLocalTopLevelDecls()); return HighlightingTokenCollector(AST).collectTokens(); } Modified: clang-tools-extra/trunk/clangd/SemanticHighlighting.h URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/SemanticHighlighting.h?rev=364528&r1=364527&r2=364528&view=diff ============================================================================== --- clang-tools-extra/trunk/clangd/SemanticHighlighting.h (original) +++ clang-tools-extra/trunk/clangd/SemanticHighlighting.h Thu Jun 27 05:22:18 2019 @@ -6,8 +6,8 @@ // //===----------------------------------------------------------------------===// -#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_SEMANTICHIGHLIGHT_H -#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_SEMANTICHIGHLIGHT_H +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_SEMANTICHIGHLIGHTING_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_SEMANTICHIGHLIGHTING_H #include "ClangdUnit.h" _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
