martong added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:8668
+
+bool ASTImporter::ImportPathTy::hasCycleAtBack() {
+ return Aux[Nodes.back()] > 1;
----------------
a_sidorin wrote:
> const?
Thanks! I made to be const.
================
Comment at: clang/lib/AST/ASTImporter.cpp:7840
+ // Push FromD to the stack, and remove that when we return.
+ ImportPathBuilder PathRAII(ImportPath, FromD);
----------------
balazske wrote:
> It is possible to use the `make_scope_exit` instead, this results in less
> written code.
Thanks! Changed to use that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62375/new/
https://reviews.llvm.org/D62375
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
