martong marked 4 inline comments as done. martong added inline comments.
================ Comment at: clang/lib/AST/ASTImporter.cpp:1724 + }; + DefinitionCompleter CompleterRAII(To); ---------------- jkorous wrote: > You might consider using just a lambda with `llvm::make_scope_exit`. > > https://llvm.org/doxygen/namespacellvm.html#a4896534f3c6278be56967444daf38e3f > > For example: > ``` > To->startDefinition(); > auto DefinitionCompleter = llvm::make_scope_exit( > [To](){To->completeDefinition();} ); > ``` Thanks! I have changed to make_scope_exit. ================ Comment at: clang/unittests/AST/ASTImporterTest.cpp:4743 +} + INSTANTIATE_TEST_CASE_P(ParameterizedTests, ErrorHandlingTest, ---------------- balazske wrote: > Maybe add a similar test for namespace and check that the error is not > propagated? Ok, I have added that test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
