leonardchan added inline comments.
================ Comment at: clang/test/CodeGen/pgo-sample.c:12-14 +// NEWPM-DAG: PostOrderFunctionAttrsPass +// NEWPM-DAG: SimplifyCFGPass +// NEWPM-DAG: SampleProfileLoaderPass ---------------- chandlerc wrote: > The DAG worries me a bit ... The point here is to check that we remove EH > before attaching sample profile data, and with the DAG it isn't clear that > this happens *before*. It turns out that `SampleProfileLoaderPass` was added before either of these. I moved this into a separate patch that addresses it since it comes with a small clang + llvm change (D63626). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63156/new/ https://reviews.llvm.org/D63156 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
