leonardchan added a comment. In D63174#1549601 <https://reviews.llvm.org/D63174#1549601>, @chandlerc wrote:
> OMG, I'm so sorry, I had no idea that the tests would explode like that... > Yeah, I don't think that's useful.... > > Maybe a better approach is to just explicitly run the code through `opt > -passes=instsimplify` before handing it to FileCheck? That should produce > almost identical results to the old PM's inliner? > > Feel free to just try this out and report back -- if it isn't looking good, > don't invest a bunch of time in it, we should talk to Craig and figure out > what the right long-term strategy here is. Hmm so `-instsimplify` and combinations of other passes like `intsnamer` and `instcombine` don't seem to clean this up any further. The IR still differs between PMs (at -O0), and I can provide the diffs if necessary. In the short term, I imagine an "ok" solution for now would be to just run the original tests with `-fno-experimental-new-pas-manager`, and either have a separate file with these new PM `-O1` checks at or separate runs in the same file to prevent regressions. I emailed Craig for his insight and info on these tests. For now I reverted back to an early diff for this with the -O0 tests only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
