aaron.ballman added inline comments.
================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3306
+def warn_xor_used_as_pow_base_two : Warning<
+ "result of '%0' is %1, maybe you mean '%2' (%3)?">,
+ InGroup<XorAsPow>;
----------------
We usually use "did you mean" in these kinds of diagnostics. Replace the comma
with a semicolon.
Same comments below.
================
Comment at: lib/Sema/SemaExpr.cpp:10895
+ SourceLocation Loc) {
+ // Do not diagnose macros
+ if (Loc.isMacroID())
----------------
Missing a full stop at the end of the comment. Same comment applies elsewhere.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63423/new/
https://reviews.llvm.org/D63423
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
