MaskRay added inline comments.
================ Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:12 +#include "clang/Frontend/FrontendActions.h" +#include "clang/Index/CodegenNameGenerator.h" +#include "clang/Sema/TemplateInstCallback.h" ---------------- > rL363646 This file references symbols from clangIndex (`#include "clang/Index/CodegenNameGenerator.h"`), so you can't remove the `clangIndex` dependency from `CMakeFiles.txt`, otherwise `-DBUILD_SHARED_LIBS=off` builds would also fail. ``` # Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO # build might work on ELF but fail on MachO/COFF. ``` The built shared library must have all of its dependencies specified on the linker command line. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
