Szelethus marked an inline comment as done. Szelethus added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:157 + /// Conditions we're already tracking. + llvm::SmallPtrSet<const Expr *, 4> TrackedConditions; + ---------------- xazax.hun wrote: > Do we need this? I wonder if marking the result of the condition as > interesting is sufficient. Later on, when I'm covering the "should-not-have-happened" case, it's possible that a condition would be added that wasn't even explored by the analyzer, so this is kinda necessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
