Charusso marked 3 inline comments as done. Charusso added a comment. @NoQ, thanks for the review! Now everything is working by rL363515 <https://reviews.llvm.org/rL363515>.
================ Comment at: cfe/trunk/test/Analysis/inlining/placement-new-fp-suppression.cpp:16 + +typedef unsigned long uintptr_t; + ---------------- Szelethus wrote: > Szelethus wrote: > > hintonda wrote: > > > I don't believe this is really ever portable, but definitely not on 64 > > > bit Windows where a long is 32 bits. > > > > > > Can't you just `#include <stdint.h>` instead? > > In the test, I'm pretty sure that he can't. > > > > I grepped `test/Analysis`, and found that `malloc.cpp` does the following: > > > > ``` > > typedef unsigned __INTPTR_TYPE__ uintptr_t > > ``` > > > > Maybe that's worth a shot? > I seem to have been proven wrong. :) I was a little-bit surprised as well. Thanks for the idea! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62926/new/ https://reviews.llvm.org/D62926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
