hfinkel added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:570 + // FIXME: libc++ dynamically links against libpthread, so for static + // linking, we need to supply that dependency. ---------------- Why does this say FIXME? ================ Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:574 + // FIXME: Again, like above, does this really make sense for all GNU + // toolchains? + WantPthread = true; ---------------- It seems to me that, in general, the answer will be yes. std::thread is built on pthreads, generally, and if we need to change this for particular systems, then that can always be done as a special case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63329/new/ https://reviews.llvm.org/D63329 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
