[PATCH] D63149: Added AST matcher for ignoring elidable constructors

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr added inline comments.


================
Comment at: clang/unittests/ASTMatchers/ASTMatchersTest.h:69
+  CXX17OrLater,
+  CXX2AOrLater
+};
----------------
Cxx2aOrLater?

(no need to uppercase things)


================
Comment at: clang/unittests/ASTMatchers/ASTMatchersTest.h:159
+    switch (Mode) {
+    case LanguageMode::CXX11OrLater:
+    case LanguageMode::CXX11:
----------------
The "orlater" variants should not appear here, please use "default: 
llvm_unreachable()".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63149/new/

https://reviews.llvm.org/D63149



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits