efriedma added a comment.
The general idea of restricting the intrinsics to specific contexts makes
sense. I'm not sure it makes sense to mark expressions, as opposed to types,
though; can we really expect the user to know which expressions to apply this
to?
I'd like to see an actual specification for this in docs/LanguageExtensions.rst
at some point.
Other than that, generally seems okay.
================
Comment at: lib/CodeGen/CGExpr.cpp:663
+ while (true) {
+ const auto &Parents = getContext().getParents(*E);
+ if (Parents.size() != 1)
----------------
I'm not sure you can use getParents like this safely... it's not really meant
for use inside of clang semantic analysis/code generation, and I don't think we
recompute it as the AST changes.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61809/new/
https://reviews.llvm.org/D61809
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
