rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/AST/ASTContext.cpp:9809 + // variable template specializations inline. + if (isa<VarTemplateSpecializationDecl>(VD) && VD->isConstexpr()) + return GVA_DiscardableODR; ---------------- It'd be nice to include a note here that this is strictly non-conforming (since another TU could be relying on this TU to provide the definition), but that we don't expect that to happen in practice for variable template specializations declared `constexpr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63175/new/ https://reviews.llvm.org/D63175 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
