hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added a subscriber: jsji. Herald added a project: clang.
As suggested in the review of D62949 <https://reviews.llvm.org/D62949>, this patch updates the plist output to have a newline at the end of the file. This makes it so that the plist output file qualifies as a POSIX text file, which increases the consumability of the generated plist file in relation to various tools. Repository: rC Clang https://reviews.llvm.org/D63041 Files: lib/ARCMigrate/PlistReporter.cpp lib/StaticAnalyzer/Core/PlistDiagnostics.cpp Index: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp =================================================================== --- lib/StaticAnalyzer/Core/PlistDiagnostics.cpp +++ lib/StaticAnalyzer/Core/PlistDiagnostics.cpp @@ -748,7 +748,7 @@ } // Finish. - o << "</dict>\n</plist>"; + o << "</dict>\n</plist>\n"; } //===----------------------------------------------------------------------===// Index: lib/ARCMigrate/PlistReporter.cpp =================================================================== --- lib/ARCMigrate/PlistReporter.cpp +++ lib/ARCMigrate/PlistReporter.cpp @@ -120,5 +120,5 @@ o << " </array>\n"; // Finish. - o << "</dict>\n</plist>"; + o << "</dict>\n</plist>\n"; }
Index: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp =================================================================== --- lib/StaticAnalyzer/Core/PlistDiagnostics.cpp +++ lib/StaticAnalyzer/Core/PlistDiagnostics.cpp @@ -748,7 +748,7 @@ } // Finish. - o << "</dict>\n</plist>"; + o << "</dict>\n</plist>\n"; } //===----------------------------------------------------------------------===// Index: lib/ARCMigrate/PlistReporter.cpp =================================================================== --- lib/ARCMigrate/PlistReporter.cpp +++ lib/ARCMigrate/PlistReporter.cpp @@ -120,5 +120,5 @@ o << " </array>\n"; // Finish. - o << "</dict>\n</plist>"; + o << "</dict>\n</plist>\n"; }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
