juliehockett added a comment.
In D62970#1533229 <https://reviews.llvm.org/D62970#1533229>, @jakehehrlich
wrote:
> Actually if we can make Description a hash set that would be best. I think
> using std::set would require an awkward < operator to be defined. There
> should be standard ways of getting hashes out of all the string and vector
> types and you can use hash_combine to combine all of these into a single hash.
This SGTM -- this would actually make it a bit more deterministic in the
ordering, since we'd no longer depend on the order of file load, even.
================
Comment at: clang-tools-extra/clang-doc/Representation.cpp:139-140
DefLoc = std::move(Other.DefLoc);
// Unconditionally extend the list of locations, since we want all of them.
std::move(Other.Loc.begin(), Other.Loc.end(), std::back_inserter(Loc));
mergeBase(std::move(Other));
----------------
While you're here, could you actually do the same for Location? That is, make
it a hash set on `SymbolInfo` and dedup here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62970/new/
https://reviews.llvm.org/D62970
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
