jcai19 marked an inline comment as done.
jcai19 added inline comments.
================
Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:17
+
+void warning1() {
+ int pipefd[2];
----------------
gribozavr wrote:
> `warning1`, `warning2` is better than `a` and `b`, but we can do even better.
>
> `warningForPipeCall`
> `warningForPipeCallInMacroArgument`
>
> Similarly in the rest of the patch.
Sounds good. I have updated the function names, although I feel the
"ForPipeCall" part is already implied in the test so I did not include it to
keep the names shorter. Let me know if you think it is better to have it
included.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62049/new/
https://reviews.llvm.org/D62049
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
