jyu2 added a comment. jyu2 committed rG954ec09aed4f <https://reviews.llvm.org/rG954ec09aed4f2be04bb5f4e10dbb4ea8bd19ef9a>: clang support gnu asm goto
In D56571#1523895 <https://reviews.llvm.org/D56571#1523895>, @nickdesaulniers wrote: > Was this committed accidentally? > > Today in master I see: > > - r362106: Revert "clang support gnu asm goto." Erich Keane > <erich.ke...@intel.com> > - r362059: Mark CodeGen/asm-goto.c as x86 specific after r362045 Fangrui Song > <mask...@google.com> > - r362045: clang support gnu asm goto. Jennifer Yu <jennifer...@intel.com> > > and yet this Phabricator review is still open. > > It may be easier to rebase this into a monorepo checkout, then commit with > `git llvm push`. > https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git > > As @kees noted, for new test files that contain x86 assembly, they need a > `-triple` that specifies an x86 target, otherwise the implicit target is > based on the host, which may not be x86. We still want to verify that > non-x86 host can cross compile to x86 correctly. Sorry we did not catch this > earlier in code review. Thanks Kees and Nick! I am currently work on those tests to see if I can make them more generic. All my test using x86 instruction. So that is not working for arm or arm64 target. Will update you once I am done for this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
